Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Param names #94

Merged
merged 9 commits into from
Nov 18, 2022
Merged

Param names #94

merged 9 commits into from
Nov 18, 2022

Conversation

jnikula
Copy link
Owner

@jnikula jnikula commented Nov 17, 2022

Updated version of #93.

I'm still not entirely happy about how all the spacing happens, but I think it's passable. Fixed void functions while at it, and added some more tests.

@jnikula jnikula mentioned this pull request Nov 17, 2022
Closed
BrunoMSantos
BrunoMSantos reviewed Nov 17, 2022
View reviewed changes
hawkmoth/parser.py Outdated Show resolved Hide resolved
BrunoMSantos
BrunoMSantos approved these changes Nov 17, 2022
View reviewed changes
Copy link
Collaborator

@BrunoMSantos BrunoMSantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor nitpicks, but I can go either way. Otherwise I think it's good to go notwithstanding what we discussed in the draft version.
It's also a great clean-up of course, congrats.

jnikula and others added 9 commits November 18, 2022 15:01
@jnikula
test: add test for multi-dimensional array
cbb9a17 
We'll want to ensure the array dimensions are handled in the correct
order in upcoming changes. Add a test for it.
@jnikula
parser: pass cursor to _decl_fixup()
212ee5c 
Pass cursor to _decl_fixup() as we'll need it in upcoming changes.
@jnikula
parser: replace regexps in _decl_fixup() with actual clang parsing
5a2ef01 
Combine both array and function pointer fixups into one.

Based on the work by Robin Bourianes <robin.bourianes@kalisio.com> [1].

[1] #86
@jnikula
parser: add support for function pointer param names
ba52626 
Based on the work by Robin Bourianes <robin.bourianes@kalisio.com> [1].

[1] #86

Fixes: #69.
@robinbourianes-kalisio @jnikula
test: add function pointer struct member with parameter names test case
a564880 
[Jani: whitespace changes to reflect code changes.]
@robinbourianes-kalisio @jnikula
test: add more function pointer variable test cases
83a645f 
[Jani: whitespace changes to reflect code changes.]
@jnikula
parser: properly handle functions with no parameters
54c0171 
Fix output for functions without parameters.
@jnikula
test: clarify wording around functions without parameters
3fb607f 
Better describe the cases for no parameters and empty parameter list.
@jnikula
test: add test for variadic function
5c074ea
@jnikula jnikula merged commit b7a05d7 into master Nov 18, 2022
@jnikula jnikula deleted the param-names branch November 18, 2022 13:16
@jnikula
Copy link
Owner Author

jnikula commented Nov 18, 2022

Couple of minor nitpicks, but I can go either way. Otherwise I think it's good to go notwithstanding what we discussed in the draft version. It's also a great clean-up of course, congrats.

Thanks for the review! Fixed the code change, left the test as-is, and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrunoMSantos BrunoMSantos BrunoMSantos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jnikula @BrunoMSantos @robinbourianes-kalisio