test(cashflow): implement integration tests

This commit implements integration tests for the cashflow by services
report route.  In doing so, it caught a bug that would throw an SQL
error if there were not values to select.  This has been rectified.

Closes #165.

client/src/partials/reports/modals/cashflowByService.config.js

@@ -9,8 +9,8 @@ CashflowByServiceConfigController.$inject = [
  * CashflowByService
  *
  * @description
- * This controller is responsible of Aged Debtors report, that report include
- * all incomes minus all depenses
+ * This controller is responsible for setting up the Cashflow by Service report
+ * in the standard report controller.
  */
 function CashflowByServiceConfigController($state, $http, ModalInstance, Notify, Languages, reportDetails) {
   var vm = this;

server/controllers/finance/reports/cashflow/index.js

@@ -599,6 +599,7 @@ function reportByService(req, res, next) {
   }
 
   const data = {};
+  let emptyCashValues = false;
 
   // get the cash flow data
   const cashflowByServiceSql = `
@@ -637,6 +638,12 @@ function reportByService(req, res, next) {
     .then(rows => {
       data.rows = rows;
 
+      // return an empty array if no rows
+      if (!rows.length) {
+        emptyCashValues = true;
+        return [];
+      }
+
       // get a list of unique service ids
       let serviceIds = rows
         .map(row => row.service_id)
@@ -647,6 +654,11 @@ function reportByService(req, res, next) {
     })
     .then(services => {
 
+      // if nothing matches the selection criteria, continue with nothing
+      if (emptyCashValues) {
+        return [];
+      }
+
       let rows = data.rows;
       let uuids = rows.map(row => db.bid(row.uuid));
       delete data.rows;
@@ -656,10 +668,10 @@ function reportByService(req, res, next) {
 
       let xAxis = data.services.length;
 
-      // file the matrix with nulls except the correct columns
+      // fill the matrix with nulls except the correct columns
       let matrix = rows.map(row => {
 
-        // fill with each service + two lines for cash payment identifier and patient name
+        // fill line with each service + two lines for cash payment identifier and patient name
         let line = _.fill(Array(xAxis + 2), null);
 
         // each line has the cash payment reference and then the patient name

server/controllers/finance/reports/cashflow/reportByService.handlebars

@@ -34,6 +34,8 @@
                 </td>
               {{/each}}
             </tr>
+          {{else}}
+            {{> emptyTable columns=2}}
           {{/each}}
         </tbody>
 

test/integration/reports/finance/cashflowByService.js

@@ -0,0 +1,4 @@
+const RenderingTests = require('../rendering');
+const target = '/reports/finance/cashflow/services';
+const params = { dateFrom : new Date('2010-01-01'), dateTo: new Date() };
+describe(`(${target}) CashFlow By Service Report`, RenderingTests(target, null, params));

test/integration/services.js

@@ -83,7 +83,6 @@ describe('(/services) The Service API', function () {
       .catch(helpers.handler);
   });
 
-
   it('PUT /services/:id updates the newly added services', function () {
     var updateInfo = {name : 'other'};
     return agent.put('/services/'+ newService.id)
@@ -97,7 +96,6 @@ describe('(/services) The Service API', function () {
       .catch(helpers.handler);
   });
 
-
   it('PUT /services/:id refuses to update a service with a string as profit_center_id', function () {
     return agent.put('/services/' + newService.id)
       .send(wrongUpdateService)