Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataBuilder().none() should be optional #2

Closed
jnk-cons opened this issue Sep 24, 2023 · 0 comments · Fixed by #8
Closed

DataBuilder().none() should be optional #2

jnk-cons opened this issue Sep 24, 2023 · 0 comments · Fixed by #8
Assignees
@jnk-cons
Labels
enhancement Minor improvements
Milestone
2.1.0

Comments

@jnk-cons
Copy link
Owner

If a data block is to get the value none(), it would be easy to omit the call

Old:

DataBuilder().tag(...).none().build()

New:

DataBuilder().tag(...).build()
@jnk-cons jnk-cons added the enhancement Minor improvements label Sep 24, 2023
@jnk-cons jnk-cons added this to the 2.1.0 milestone Sep 24, 2023
@jnk-cons jnk-cons self-assigned this Sep 24, 2023
jnk-cons added a commit that referenced this issue Sep 25, 2023
@jnk-cons
#2 - Made none() call optional
d115aba
@jnk-cons jnk-cons mentioned this issue Sep 25, 2023
Merged
@jnk-cons jnk-cons linked a pull request Sep 25, 2023 that will close this issue
#2 - Made DataBuilder().none() call optional #8
Merged
jnk-cons added a commit that referenced this issue Sep 25, 2023
@jnk-cons
#2 - Made DataBuilder().none() call optional (#8)
4c4233c
jnk-cons added a commit that referenced this issue Jan 22, 2024
@jnk-cons
Release 2.1.0 (#20)
9490980 
* added develop branch for the next release

* #2 - Made DataBuilder().none() call optional (#8)

* #3 - values() call replaced by entries (kotlin 1.9) (#10)

* #6 - added documentation for EMSTag.MODE and EMSTag.REQ_MODE (#11)

* #7 - added documentation for EMSTag.BALANCED_PHASES and EMSTag.REQ_BALANCED_PHASES (#12)

* #13 - Added BatterySystem service + a bunch of new Bat Tags. (#16)

* #14 - Updated SLF4j, BouncyCastle, JUnit and mockk to there newest versions (#18)

* #15 - Added TypeScript examples, linked easy-rscp-js (#19)

* Set version to 2.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnk-cons jnk-cons

Labels
enhancement Minor improvements
Projects
None yet
Milestone
2.1.0
1 participant
@jnk-cons