Update ARM32 binary with hardfp version. #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most likely targets for JRuby on ARM32 are going to be ARMv7 or higher, and it seems recent Linux distributions for ARM32 now build with hardfp support, or at least that appears to be the case for Debian, Rasbian, and Fedora. This change will prevent jffi from booting on softfp-only systems.
This was referenced Oct 30, 2018
|
I think we're going to run with this. It only affects 32-bit ARM, which doesn't work at all on at least recent Rasbian and probably wouldn't work on any recent Debian, Fedora, or Arch (three dists I confirmed have moved to hardfp). If we need to support both hardfp and softfp there will be larger changes required, since we don't have any logic to distinguish the two EABIs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most likely targets for JRuby on ARM32 are going to be ARMv7 or
higher, and it seems recent Linux distributions for ARM32 now
build with hardfp support, or at least that appears to be the case
for Debian, Rasbian, and Fedora. This change will prevent jffi
from booting on softfp-only systems.
This addresses jruby/jruby#5362, jruby/jruby#5192, and possibly #57.