Move abstract implementations from jnr-unixsocket #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etehtsea
changed the title
|
@etehtsea I missed this one :-( Still out there? |
|
Going to close this for lack of activity...contact me directly if we can give this another try! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move enxio related code recently added here in order to reduce code duplication which can lead to reappearing errors like this one.
At the moment there are still a lot of duplicated code, but I'm not sure how to properly fix it without API breakage, because
NativeSocketextendsAbstractSelectableChannel, whileAbstractNativeSocketextendsSocketChannel. @headius @enebo any ideas?P.S. Is java6 still supported?