Added endianness member methods to Platform.java #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmine if either `isBigEndian()` or `isLittleEndian()` using the system property `sun.cpu.endian`. Fixed missing import from jnr#259
|
Nice! I wonder if you saw #260 I filed a couple days ago? There are several other platform-detection tricks and APIs in jnr-posix and jnr-enxio. I believe we should pull these all into jnr-ffi since platform detection is nearly universal across all consumers. Also thanks for fixing the missing import. Not sure how I missed the failing build but perhaps there was a merge issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added endianness member methods (non static) to
Platform.javato determine if eitherisBigEndian()orisLittleEndian()using the system propertysun.cpu.endian.Fixed missing import from #259