Map null callback objects to null pointers #77
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing null as value for a callback parameter to a native function a native closure gets created which wraps a null callable. A non-null pointer then gets passed to the native code. When the java closure gets invoke this triggers a null pointer exception at https://github.com/jnr/jnr-ffi/blob/master/src/main/java/jnr/ffi/provider/jffi/NativeClosureProxy.java#L57
Additionally this can end up changing the semantics of the function call since a non-null parameter is passed where null was intended. This is what's happening in #61.
This PR adds a null check in the 'to native' conversion of delegate types that returns a null Pointer instance.