Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnixServerSocketChannel.accept() should return null in non-blocking mode #31

Closed
normanmaurer opened this issue Jun 1, 2016 · 1 comment
Closed

UnixServerSocketChannel.accept() should return null in non-blocking mode #31

normanmaurer opened this issue Jun 1, 2016 · 1 comment
Milestone
0.13

Comments

@normanmaurer
Copy link

UnixServerSocketChannel.accept() should return null in non-blocking mode when there are no more client channels to accept. At the moment it throws a Exception which is wasteful as this is expensive.

https://github.com/jnr/jnr-unixsocket/blob/master/src/main/java/jnr/unixsocket/UnixServerSocketChannel.java#L59
@marcuslinke marcuslinke mentioned this issue Jun 10, 2016
Closed
@headius
Copy link
Member

headius commented Sep 28, 2016

Agreed. Fixing. PR a test for me?

@headius headius added this to the 0.13 milestone Sep 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13
Development

No branches or pull requests
2 participants
@headius @normanmaurer