Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide JPMS module name #61

Closed
sbordet opened this issue Oct 22, 2018 · 2 comments
Closed

Provide JPMS module name #61

sbordet opened this issue Oct 22, 2018 · 2 comments
Milestone

Comments

@sbordet
Copy link
Contributor

sbordet commented Oct 22, 2018

Would be great if a stable JPMS module name can be provided, as simply as adding Automatic-Module-Name to the manifest in the jar.

This will allow projects that are moving to proper JPMS modules to reference a stable JPMS name for jnr-unixsocket in their module-info.java.

I would suggest to not use com.github as prefix, but perhaps just org.jnr, but it's ultimately your choice.

Thanks!

@sbordet
Copy link
Contributor Author

sbordet commented Oct 22, 2018

Also, jnr-unisocket has a split package with jnr-enxio: jnr.enxio.channels.

This makes impossible to use jnr-unixsocket as JPMS module, even adding the Automatic-Module-Name entry.

@headius
Copy link
Member

headius commented Feb 11, 2019

Fixed along with #58.

@headius headius closed this as completed Feb 11, 2019
@headius headius added this to the 0.22 milestone Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants