Fix #60 (calling close on a UnixSocket with a pending read waits for the read to time out on Linux) #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This passes on OS X and fails on Linux and is the cause of square/okhttp#4233.
|
I have tested this on both Linux and OS X, this change may reveal other issues on other OSes. |
|
Any chance to get this PR merged and maybe a new release ? |
|
@headius Is there anything I can help to get a release with this fix included? It looks like that this PR fixes are long outstanding (and difficult) bug in d-m-p when accessing the same socket from multiple threads. Unfortunately I'm not deep enough in the weeds to make a qualified review for this PR but I got reports that this will indeed fix that prio1 bug over there in d-m-p land. Happy new year btw ;-) |
|
Sorry about delays...cycling back through JNR stuff now! |
headius
approved these changes
Jan 9, 2020
|
I'll push out a release today! |
|
@headius awesome, thanks a ton ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #60 for details.