Fixes string casting of paths that may contains Unicode characters. #199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed the
user_data_directory
string casting, which will causes some unexcepted behaviors if string contains Unicode characters:1. If the user has permission to create directorys, for example:
Excepted user data directory:
Actually user data directory:
The WebView2 will creates the directory as a garbled name
ᄐモ¥ᆳリ
, which is unexcepted.2. If the user does not have write permission, for example, a windows username with Unicode characters:
Excepted user data directory:
Actually user data directory:
This time the Weview2 will try to create directories
C:\Users\ᄐモ¥ᆳリ
and may got failed.