job-fix-race-condition-v4
jnsnow
tagged this
08 Nov 05:56
There are a few problems with transactional job completion right now. First, if jobs complete so quickly they complete before remaining jobs get a chance to join the transaction, the completion mode can leave well known state and the QLIST can get corrupted and the transactional jobs can complete in batches or phases instead of all together. Second, if two or more jobs defer to the main loop at roughly the same time, it's possible for one job's cleanup to directly invoke the other job's cleanup from within the same thread, leading to a situation that will deadlock the entire transaction. Thanks to Vladimir for pointing out these modes of failure. === v4: === Key: [----] : patches are identical [####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively 001/6:[----] [--] 'blockjob: fix dead pointer in txn list' 002/6:[----] [--] 'blockjob: add .clean property' 003/6:[----] [--] 'blockjob: add .start field' 004/6:[0021] [FC] 'blockjob: add block_job_start' 005/6:[0010] [FC] 'blockjob: refactor backup_start as backup_job_create' 006/6:[----] [--] 'iotests: add transactional failure race test' 04: Fix command tracers (Kevin) Implement the ability to 'start' a 'paused' job (Kevin, Jeff) 05: Replace superfluous conditionals with assertions. (Kevin, Jeff) === v3: === - Rebase to origin/master, requisite patches now upstream. === v2: === - Correct Vladimir's email (Sorry!) - Add test as a variant of an existing test [Vladimir] ________________________________________________________________________________ For convenience, this branch is available at: https://github.com/jnsnow/qemu.git branch job-fix-race-condition https://github.com/jnsnow/qemu/tree/job-fix-race-condition This version is tagged job-fix-race-condition-v4: https://github.com/jnsnow/qemu/releases/tag/job-fix-race-condition-v4
Assets 2
-
2016-11-08T05:56:50Z -
2016-11-08T05:56:50Z -