Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #130

Merged
merged 4 commits into from
Aug 12, 2021
Merged

Cleanup #130

merged 4 commits into from
Aug 12, 2021

Conversation

nixypanda
Copy link
Contributor

Building on top of previous PRs this just does some basic cleanup

  • Remove un-necessary indirections from engine to editor functions
  • Remove dead code - partial_command
  • Make undo/redo interface consistent with other editor functions
  • abstract up/down command logic to appropriate units

Reviewer Note: This is meant to be reviewed when the base is #129

sholderbach
sholderbach reviewed Aug 3, 2021
View reviewed changes
src/engine.rs Outdated Show resolved Hide resolved
src/engine.rs Outdated Show resolved Hide resolved
@nixypanda nixypanda mentioned this pull request Aug 3, 2021
Merged
@sophiajt
Copy link
Contributor

Nice to see it all come together. Looks good

@sophiajt sophiajt merged commit ade4172 into nushell:main Aug 12, 2021
@nixypanda nixypanda mentioned this pull request Sep 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sholderbach sholderbach sholderbach left review comments

@mzanrosso mzanrosso mzanrosso left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nixypanda @sophiajt @sholderbach @mzanrosso