Pull undo redo to editor #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nixypanda
commented
Jul 28, 2021
Merged
nixypanda
commented
Jul 28, 2021
nixypanda
force-pushed
the
pull-undo-redo-to-editor
branch
from
8f9d9dd
to
1e475b2
Compare
Merged
nixypanda
force-pushed
the
pull-undo-redo-to-editor
branch
4 times, most recently
from
23e200c
to
c9a0a38
Compare
nixypanda
commented
Aug 12, 2021
nixypanda
force-pushed
the
pull-undo-redo-to-editor
branch
from
c9a0a38
to
8e9c105
Compare
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to create this on the branch that I have requested to merge but looks like I can't really do that as that branch does not exist in this repo. (Sigh: github should really allow for creating PRs over other PRs :P)
Anyway, this is a simplification of pulling out the undo and redo functionality into the editor struct whilst also simplifying it a bit.
NOTE TO Reviewers: #128 does most of the work on which this build on. Only take a look at the last commit in this PR