Adding methods with a generic name to a core Ruby class (and therefore all instances of that class) is not a good idea. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e all instances of that class) is not a good idea. Crack was defining [1] `attributes` accessor methods on the core Ruby `String` class which in turn caused a very difficult to track down bug when using Mongoid, because of this [2]. This commit changes Crack so it just defines the `attributes` accessor methods on the relevant instances of `String`. [1] https://github.com/jnunemaker/crack/blob/master/lib/crack/xml.rb#L85 [2] https://github.com/mongoid/mongoid/blob/master/lib/mongoid/relations/builder.rb#L38
|
@floehopper, great find!... a number of hours into debugging I narrowed the issue to httparty/crack, and google brought me here... you saved me more hours of debugging to find the exact line. +1 on this... it is causing all kinds of weird very hard to track down issues in Mongoid. |
|
Cool. It's just a shame you had to go through any of the debugging, given this patch was offered months ago and still hasn't been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your work on Crack. This patch fixes a nasty problem I was having when using Savon (and therefore Crack) in the same project as Mongoid. I will also try and suggest a way for Mongoid to make itself a bit more robust, but I think this change (or something similar) to Crack is a no brainer.