Use named parameters for safe_load.
#73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is available since Psych 3.1 [[1], [2]], but mandatory since Psych 4.0 [[3]]. Fixes jnunemaker#72 [1]: ruby/psych#358 [2]: ruby/psych#378 [3]: ruby/psych@0767227
|
Thanks for sending in this PR, but finally we picked #74 to solve this issue as it was a bit more general solution. Feel free to re-open this PR or start a new one if you think otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is available since Psych 3.1 [1, 2], but mandatory since Psych 4.0 [3].
Of course the question is if this is acceptable with regard to backward compatibility, because if I am not mistaken Psych 3.1 was introduced in Ruby 2.6.
Fixes #72