Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release #79

Merged
merged 6 commits into from
Jan 29, 2024
Merged

New release #79

merged 6 commits into from
Jan 29, 2024

Conversation

kiskoza
Copy link
Collaborator

@kiskoza kiskoza commented Jan 26, 2024

We already have a few fixes merged in, we should do a release soon to make sure that this gem remains usable.

ToDo:

  • Set up a CI to verify the code changes
  • Review open PRs and merge them if they make sense
  • Go through the open issues and verify if they are still a problem
  • Write a changelog in History
  • Refresh the readme
  • Bump version number
  • Make a new tag and release the new version

My Questions:

Should we add a minimum Ruby version?

I wasn't able to set up the environment for Ruby <2.0, and there are already EOL for ages.

Should we release it as 1.0.0 as well?

The gem seems to be really stable, but most of the gems / projects are referencing it as ~> 0.4.x, so we definitely need a 0.4.6 first.

@kiskoza kiskoza force-pushed the release-0.4.6 branch 2 times, most recently from ec92f81 to 891b67d Compare January 29, 2024 09:54
@kiskoza kiskoza marked this pull request as ready for review January 29, 2024 09:57
@kiskoza
Copy link
Collaborator Author

kiskoza commented Jan 29, 2024

@bf4 @jnunemaker I'm ready with all the pre-release tasks I wanted to do before we can release the new v0.4.6 version 🎉

I'm happy to merge in this PR and tag the new release commit in the repo any time from now. Let me know if you would like to add anything else.

Also, could you help me with releasing it to RubyGems?

History Outdated Show resolved Hide resolved
@@ -1,25 +1,26 @@
# crack

[![Build Status](https://travis-ci.org/jnunemaker/crack.svg?branch=master)](https://travis-ci.org/jnunemaker/crack)
[![Test](https://github.com/jnunemaker/crack/actions/workflows/test.yml/badge.svg)](https://github.com/jnunemaker/crack/actions/workflows/test.yml)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bf4
Copy link
Collaborator

bf4 commented Jan 29, 2024

Looks good

@bf4 bf4 merged commit 5022ba5 into jnunemaker:master Jan 29, 2024
15 of 16 checks passed
@bf4
Copy link
Collaborator

bf4 commented Jan 29, 2024

Released 0.4.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants