Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return :on for state if percentage of time/actors is 100 #52

Closed
jnunemaker opened this issue Apr 24, 2015 · 3 comments · Fixed by #59
Closed

Return :on for state if percentage of time/actors is 100 #52

jnunemaker opened this issue Apr 24, 2015 · 3 comments · Fixed by #59

Comments

@jnunemaker
Copy link
Collaborator

No description provided.

@aroben
Copy link
Contributor

aroben commented Apr 24, 2015

Similarly, :off should only be returned if the percentages are 0 and the groups/actors gates are empty.

@jnunemaker
Copy link
Collaborator Author

@aroben I believe it already returns :off for that. I made a few specs locally and they were correct.

@aroben
Copy link
Contributor

aroben commented Apr 24, 2015

Oh nice!

jnunemaker added a commit that referenced this issue Apr 24, 2015
@jnunemaker
Make percentages set to 100 return state of :on
c2ae080 
Fixes #52
@jnunemaker jnunemaker mentioned this issue Apr 24, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make percentages enabled to 100 return state of :on flippercloud/flipper
2 participants
@jnunemaker @aroben