Http tweaks #235
Merged
Http tweaks #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Config felt overly complex for what is going on here. Might bring it back but I don't think we need it just yet.
to_json is from rails which might not be around. It just happens to be here because we explicitly test against rails versions.
It isn't a single request, it is a class for making requests.
I can't find in docs where the other way was working but it was so I'm confused. I know this way works as it is old as dirt.
Before it was in two. Feels better to have client just do http stuff for now and not know json.
|
I'd still like to go farther on this class and make it a full wrapper around the api (e.g.: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_jsontoJSON.generate. I didn't realize thatto_jsonexists in ruby and thought that was only coming from rails which might not always be there so I switched. I later realized thatto_jsondoes seem to be there in ruby for some things, though I'm not sure it is for hash (that maybe comes from rails?). Just seemed best to be explicit and useJSON.generate.