Add Flipper Cache Store .gemspec #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnunemaker
approved these changes
Jun 14, 2017
flipper-cache-store.gemspec
Outdated
| Gem::Specification.new do |gem| | ||
| gem.authors = ['John Nunemaker'] | ||
| gem.email = ['nunemaker@gmail.com'] | ||
| gem.summary = 'ActiveSupport: Cache::Store adapter for Flipper' |
There was a problem hiding this comment.
Any particular reason this is different from description other than the warning when building the gem from the gemspec? If not, I'd probably let them be identical.
There was a problem hiding this comment.
nope, making them identical! Must have not had my coffee this am
* Has an ActiveSupport dependency so publish as own gem
AlexWheeler
force-pushed
the
flipper-cache-store-gemspec
branch
from
8191687
to
a43e9fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #267
Docs PR up #268