Fix double enable of actor/group unique error

.rubocop.yml

@@ -43,3 +43,6 @@ RSpec/InstanceVariable:
 
 Style/AccessorMethodName:
   Enabled: false
+
+Lint/HandleExceptions:
+  Enabled: false

lib/flipper/adapters/active_record.rb

@@ -113,24 +113,9 @@ def get_all
       def enable(feature, gate, thing)
         case gate.data_type
         when :boolean, :integer
-          @gate_class.transaction do
-            @gate_class.where(
-              feature_key: feature.key,
-              key: gate.key
-            ).delete_all
-
-            @gate_class.create! do |g|
-              g.feature_key = feature.key
-              g.key = gate.key
-              g.value = thing.value.to_s
-            end
-          end
+          enable_single(feature, gate, thing)
         when :set
-          @gate_class.create! do |g|
-            g.feature_key = feature.key
-            g.key = gate.key
-            g.value = thing.value.to_s
-          end
+          enable_multi(feature, gate, thing)
         else
           unsupported_data_type gate.data_type
         end
@@ -178,6 +163,28 @@ def unsupported_data_type(data_type)
 
       private
 
+      def enable_single(feature, gate, thing)
+        @gate_class.transaction do
+          @gate_class.where(feature_key: feature.key, key: gate.key).delete_all
+          @gate_class.create! do |g|
+            g.feature_key = feature.key
+            g.key = gate.key
+            g.value = thing.value.to_s
+          end
+        end
+      end
+
+      def enable_multi(feature, gate, thing)
+        @gate_class.create! do |g|
+          g.feature_key = feature.key
+          g.key = gate.key
+          g.value = thing.value.to_s
+        end
+      rescue ::ActiveRecord::RecordNotUnique
+      rescue ::ActiveRecord::StatementInvalid => error
+        raise unless error.message =~ /unique/i
+      end
+
       def result_for_feature(feature, db_gates)
         db_gates ||= []
         result = {}

lib/flipper/adapters/sequel.rb

@@ -127,11 +127,13 @@ def enable(feature, gate, thing)
               key: gate.key.to_s,
             }
             @gate_class.where(args).delete
-
             @gate_class.create(gate_attrs(feature, gate, thing))
           end
         when :set
-          @gate_class.create(gate_attrs(feature, gate, thing))
+          begin
+            @gate_class.create(gate_attrs(feature, gate, thing))
+          rescue ::Sequel::UniqueConstraintViolation
+          end
         else
           unsupported_data_type gate.data_type
         end

lib/flipper/spec/shared_adapter_specs.rb

@@ -258,4 +258,15 @@
     expect(stats).to eq(subject.default_config.merge(boolean: 'true'))
     expect(search).to eq(subject.default_config)
   end
+
+  it 'can double enable an actor without error' do
+    actor = Flipper::Actor.new('Flipper::Actor;22')
+    expect(subject.enable(feature, actor_gate, flipper.actor(actor))).to eq(true)
+    expect(subject.enable(feature, actor_gate, flipper.actor(actor))).to eq(true)
+  end
+
+  it 'can double enable a group without error' do
+    expect(subject.enable(feature, group_gate, flipper.group(:admins))).to eq(true)
+    expect(subject.enable(feature, group_gate, flipper.group(:admins))).to eq(true)
+  end
 end

lib/flipper/test/shared_adapter_test.rb

@@ -253,6 +253,17 @@ def test_can_get_all_features
         assert_equal @adapter.default_config.merge(boolean: 'true'), stats
         assert_equal @adapter.default_config, search
       end
+
+      def test_can_double_enable_an_actor_without_error
+        actor = Flipper::Actor.new('Flipper::Actor;22')
+        assert_equal true, @adapter.enable(@feature, @actor_gate, @flipper.actor(actor))
+        assert_equal true, @adapter.enable(@feature, @actor_gate, @flipper.actor(actor))
+      end
+
+      def test_can_double_enable_a_group_without_error
+        assert_equal true, @adapter.enable(@feature, @group_gate, @flipper.group(:admins))
+        assert_equal true, @adapter.enable(@feature, @group_gate, @flipper.group(:admins))
+      end
     end
   end
 end