Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove symlink #529

Merged
merged 1 commit into from
May 12, 2017
Merged

remove symlink #529

merged 1 commit into from
May 12, 2017

Conversation

ahorek
Copy link
Contributor

@ahorek ahorek commented May 12, 2017

6888e53
fixes #528

Is it safe to just remove the symlink from the repository?

ahorek referenced this pull request May 12, 2017
Ensures all test related files are not included.
@jnunemaker
Copy link
Owner

I think removing is safe. Honestly I'm not sure why it exists. It doesn't seem to be used and CI passes. Is 0.15.1 not installing for you? I have some who have confirmed install in prod no problem.

@jnunemaker jnunemaker merged commit 56ba8ba into jnunemaker:master May 12, 2017
@ahorek
Copy link
Contributor Author

ahorek commented May 12, 2017

it is autogenerated by this command c_rehash generated in
https://github.com/jnunemaker/httparty/blob/master/spec/fixtures/ssl/generate.sh#L15

unfortunatelly 0.15.1 didn't solve the problem because specs with this symlink are still included in a .gem file. It affects mainly windows users, but the same issue teoreticaly can happen on linux if you're using a filesystem, that doesn't support symlinks.
We're already using this version on our production linux systems and it works just fine, thanks again for your effort!

@jnunemaker
Copy link
Owner

0.15.2 is out with symlink removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

httparty-0.15.0.gem fail on windows
2 participants