add frozen_string_literal pragma to all files #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jnunemaker ping. |
|
@ritikesh Hi there! Thanks for the ping as this had slipped past me. Did you check each of the files to see if there were any modification of strings that would cause problems with this or just add the magic comment? I know the tests are passing, but I won't claim 100% test coverage. I just don't want to break anything for anyone. |
|
Hi @jnunemaker, guilty of over-depending on the tests. I'll have a look and give you a confirmation on the same. Thanks! |
|
Hey @jnunemaker, I looked at the code. Things look okay to me. I did modify some code however:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.