Skip to content
This repository has been archived by the owner on Jun 25, 2023. It is now read-only.

Extend functionality to apt-listchanges #57

Closed
dnmvisser opened this issue Dec 8, 2018 · 2 comments
Closed

Extend functionality to apt-listchanges #57

dnmvisser opened this issue Dec 8, 2018 · 2 comments

Comments

@dnmvisser
Copy link
Contributor

dnmvisser commented Dec 8, 2018

If unattended_mail is set, the logs will be mailed.
The default in Debian Stretch is to automagically install security updates, and in this case it would be nice to know what the changelog for these packages was.
This is done with apt-listchanges, which is triggered by default from /etc/apt/apt.conf.d/20listchanges. By default the apt-listchanges configuration file /etc/apt/listchanges.conf` lists:

which=news

Which for unattended installs such as apt, does not send mail.

Hence it would be a nice idea to expand this role so that:

  1. the email_address in /etc/apt/listchanges.conf is also set to the value to unattended_mail.
  2. introduce a new config option (unattended_mail_listchanges that sets which=both.

This should probably be done with the ini module, as /etc/apt/listchanges.conf is an ini file.

I can contribute with a PR if there is interest

@jnv
Copy link
Owner

jnv commented Dec 10, 2018

Thanks for the suggestion and the PR, Dick!

I am a bit wary of scope creep, because this goes beyond the configuration of unattended-upgrades as a sole responsibility of this role; apt-listchanges can be configured by a separate role. On the other hand, this seems to be recommended on Debian Wiki and it makes sense to configure these packages in tandem.

I will be happy to include this if:

  • It works in all supported distributions (i.e. Debian stable, Ubuntu LTS) – or doesn't break them.
  • It is an opt-in functionality, for example I need to explicitly set unattended_mail_listchanges_which or use a different flag to have apt-listchanges installed and configured, so it doesn't cause a conflict by default.

I also wonder if the listchanges configuration can be written to different file rather than /etc/apt/listchanges.conf, I guess changing the default configuration file may cause conflicts during upgrade, as seen in #10.

@jnv
Copy link
Owner

jnv commented May 23, 2022

I am closing this issue since this role has been deprecated. Feel free to suggest alternatives in #98.

@jnv jnv closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants