Skip to content
This repository has been archived by the owner on Jun 25, 2023. It is now read-only.

Default configuration should use AllowedOrigins in Ubuntu #82

Closed
Chithrak07 opened this issue Apr 19, 2021 · 3 comments
Closed

Default configuration should use AllowedOrigins in Ubuntu #82

Chithrak07 opened this issue Apr 19, 2021 · 3 comments

Comments

@Chithrak07
Copy link

Chithrak07 commented Apr 19, 2021

The current jnv role is applying old syntax to new machines.

The section origins-pattern seems to have changed to allowed-origins as of 18.04.

@jnv
Copy link
Owner

jnv commented Apr 23, 2021

Thanks for the report. It seems the usage of OriginsPattern vs. AllowedOrigins is distribution-specific, compare the upstream configuration for Debian vs. Ubuntu. My understanding of these choices is that OriginsPattern is more powerful and should be backwards compatible with AllowedOrigins, but I can be mistaken.

Anyway, feel free to submit a fix to use AllowedOrigins instead of OriginsPattern on Ubuntu.

@jnv jnv changed the title Support Ubuntu versions greater than 16.04 Default configuration should use AllowedOrigins in Ubuntu Apr 23, 2021
@dale-c-anderson
Copy link

@jnv that actually explains a lot.

Any chance #66 is going to get merged in soon? If not, we'll fork form Consensus's role until it all makes it to master in yours.

@jnv
Copy link
Owner

jnv commented May 23, 2022

I am closing this issue since this role has been deprecated. Feel free to suggest alternatives in #98.

@jnv jnv closed this as not planned Won't fix, can't repro, duplicate, stale May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants