New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LMDB_FORCE_SYSTEM modes to the builds #188
Conversation
Hm, is the version of lmdb in apt significantly different from the one you test with? |
Yes, the version in |
I'm not sure Windows+System Library makes sense? Unless you mean "install LMDBWindows separately and build from that". |
Yes, maybe Windows+library is skippable.. most users there expect a prebuilt solution |
Travis is Ubuntu Precise and Trusty (wow, they need to update their build environments). From packages.ubuntu.com:
From packages.debian.org:
I guess, what versions of lmdb do you want to support compiling against? |
A maintainer's opinion on this would be really great. |
I haven't tuned in for a while, but I believe upstream LMDB only have a single stable branch. In that case, the latest version should be bundled with py-lmdb and we should just try building against whatever is available in the CI VM already, or if nothing is available, simply try against any old version. Really the original ticket is about ensuring setup.py works. Thanks a ton for looking at this -- my hands are completely full on another project just now. |
In general, most projects don't merge PRs that break their CI. In the course of implementing #92, I have uncovered a new bug. The two popular options are:
Ideally, I would add the versions of LMDB that are shipped with major distributions to the matrix. However, Travis does not easily allow this. (The straightforward option is to refactor the CI to run inside a container, which is entirely manual and kinda annoying on Travis.) So, as maintainers, would you rather add support for older versions (given that both Ubuntu and Debian--and presumably other distributions--ship older versions), or drop support for compiling against the system library? |
Fixes #92