Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LMDB_FORCE_SYSTEM modes to the builds #188

Closed
wants to merge 3 commits into from

Conversation

AstraLuma
Copy link
Contributor

Fixes #92

@AstraLuma
Copy link
Contributor Author

Hm, is the version of lmdb in apt significantly different from the one you test with?

@AstraLuma
Copy link
Contributor Author

Yes, the version in lib is 0.9.22, but the version Travis installs from apt is 0.9.10.

@AstraLuma
Copy link
Contributor Author

I'm not sure Windows+System Library makes sense? Unless you mean "install LMDBWindows separately and build from that".

@dw
Copy link
Collaborator

dw commented Oct 26, 2018

Yes, maybe Windows+library is skippable.. most users there expect a prebuilt solution

@AstraLuma
Copy link
Contributor Author

Travis is Ubuntu Precise and Trusty (wow, they need to update their build environments).

From packages.ubuntu.com:

  • trusty: 0.9.10-1
  • trusty-backports: 0.9.16-1~ubuntu14.04.1
  • xenial: 0.9.17-3
  • xenial-backports: 0.9.18-4~ubuntu16.04.1
  • artful: 0.9.21-1
  • bionic: 0.9.21-1
  • cosmic: 0.9.22-1

From packages.debian.org:

  • jessie (oldstable): 0.9.14-1:kfreebsd-amd64 kfreebsd-i386
  • jessie-backports: 0.9.18-1~bpo80+1
  • stretch (stable): 0.9.18-5
  • buster (testing): 0.9.22-1
  • sid (unstable): 0.9.22-1 (Most archs), 0.9.21-1 (kfreebsd-*)

I guess, what versions of lmdb do you want to support compiling against?

@AstraLuma
Copy link
Contributor Author

A maintainer's opinion on this would be really great.

@dw
Copy link
Collaborator

dw commented Nov 1, 2018

I haven't tuned in for a while, but I believe upstream LMDB only have a single stable branch. In that case, the latest version should be bundled with py-lmdb and we should just try building against whatever is available in the CI VM already, or if nothing is available, simply try against any old version. Really the original ticket is about ensuring setup.py works.

Thanks a ton for looking at this -- my hands are completely full on another project just now.

@AstraLuma
Copy link
Contributor Author

AstraLuma commented Nov 2, 2018

In general, most projects don't merge PRs that break their CI.

In the course of implementing #92, I have uncovered a new bug.

The two popular options are:

  • Fix the new bug (likely in a new bug/PR), merge that, then merge this
  • Reconsider the original bug and if you really want that

Ideally, I would add the versions of LMDB that are shipped with major distributions to the matrix. However, Travis does not easily allow this. (The straightforward option is to refactor the CI to run inside a container, which is entirely manual and kinda annoying on Travis.)

So, as maintainers, would you rather add support for older versions (given that both Ubuntu and Debian--and presumably other distributions--ship older versions), or drop support for compiling against the system library?

@jnwatson jnwatson closed this Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI tests for every build type.
3 participants