Fix archive containing a single invalid symbol #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an archive contains a single symbol whose target doesn't exist (like gcc's libgo testsuite for the tar module) then neither ref $unpacked nor -e $unpacked is true (because unpacking causes no error, but still the file doesn't exist in -e parlance). The if cascade after it explicitely checks for symlink-ness of $unpacked and does the right thing (removing it), so just don't die prematurely if $unpacked is a symlink.
|
Nice find and explanation. 👍 |
|
Yeah, well, I'm very interested in gcc7 progressing in legaldb ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an archive contains a single symbol whose target doesn't exist
(like gcc's libgo testsuite for the tar module) then neither
ref $unpacked nor -e $unpacked is true (because unpacking causes
no error, but still the file doesn't exist in -e parlance). The
if cascade after it explicitely checks for symlink-ness of
$unpacked and does the right thing (removing it), so just don't
die prematurely if $unpacked is a symlink.