Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using github-app-installation-token pacakge + esbuild #4

Closed
wants to merge 5 commits into from
Closed

Using github-app-installation-token pacakge + esbuild #4

wants to merge 5 commits into from

Conversation

gagoar
Copy link
Collaborator

@gagoar gagoar commented Nov 4, 2020

This PR changes a couple of things:

  1. it uses github-app-installation-token
  2. It changes ncc for esbuild due to the known issues with is-plain-object and octokit/rest
  3. changed fetch-mock in favor of nock for convenience.

@gagoar gagoar changed the title using github-app-installation-token Using github-app-installation-token pacakge + esbuild Nov 4, 2020
@gagoar
Copy link
Collaborator Author

gagoar commented Nov 4, 2020

some steps are failing because secrets aren't in my repo.

jnwng
jnwng requested changes Nov 4, 2020
View reviewed changes
__tests__/main.test.ts Outdated Show resolved Hide resolved
package.json Outdated
Comment on lines 28 to 29
"@types/nock": "^11.1.0",
"esbuild": "^0.8.3",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should be devDependencies

@gagoar gagoar mentioned this pull request Nov 4, 2020
Merged
@gagoar
Copy link
Collaborator Author

gagoar commented Nov 4, 2020

closed in favour of #5

@gagoar gagoar closed this Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnwng jnwng jnwng requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gagoar @jnwng