Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help building v5 #17

Closed
denis-sokolov opened this issue Jun 1, 2015 · 4 comments
Closed

Help building v5 #17

denis-sokolov opened this issue Jun 1, 2015 · 4 comments

Comments

@denis-sokolov
Copy link
Contributor

I would be willing to work on version 5 if you would accept fairly big changes that fix #14, #15, and #16.
I do not with to fork because to keep the efforts in one place, and to promote the visibility of existing problems in this library.

@jo
Copy link
Owner

jo commented Jun 1, 2015

Hi @denis-sokolov thank you very much for your feedback. Your help is very much appreciated!

About v5 I am open for fundamental changes and they can, of course, break backwards compatibility. We should take this as a chance to rethink the entire api.
I have already thought about api changes (eg. #10) and I very much like your idea in #14. Maybe that could solve the difficulties with different seperators, eg : (#13) which is a strong requirement for me.
In this context its worth to think about using template strings instead of :id and *:id, like proposed in this template url RFC.

@argl
Copy link
Collaborator

argl commented Jun 1, 2015

+1 for the changes and a v5. breaking changes? Thats why we have versioning.

@jo
Copy link
Owner

jo commented Jun 1, 2015

Semver to the rescue!

@denis-sokolov
Copy link
Contributor Author

Great. In this case I will start designing and create issues to receive feedback.
I will not implement it until your approval, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants