feat: calculate yAxisTicks based on given values #1142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMHO the
yAxisTicks
parameter forchartPage
is a little bit hard to understand, given the required formatting. Besides that, in the example theyAxisTicks
for the office temperature are from -25° to +25° C which makes no sense, at least for me.But there is really no need to provide them at all because we can caluclate the yAxisTicks based on the provided values. In this pull request there is an added algorithm which calculates the ticks if no
yAxisTicks
was provided for the page. This makes configuring thechartPage
a little bit easier and more responsive.Example debug logging:
Notice how the amount of calculated ticks changes with the given range of values to display.