Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow icons based on state of status entity #651

Merged
merged 4 commits into from
Dec 29, 2022
Merged

Conversation

EddyK69
Copy link
Contributor

@EddyK69 EddyK69 commented Dec 29, 2022

Allow icons based on state of status entity on navigate

iconOverrides on navigates & services where not shown when the status entity was of type 'sensor' on cardGrids
Allow icons based on state of status entity on navigate
@EddyK69 EddyK69 requested a review from joBr99 as a code owner December 29, 2022 14:11
Copy link
Owner

@joBr99 joBr99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how this code change is altering any functionality, moving this line into the else behave exactly like before.

Even though this it's still better to do it in the else.

@EddyK69
Copy link
Contributor Author

EddyK69 commented Dec 29, 2022

If not changed, it generates an error on this icon_res when you fill in multiple icons per state and it never reaches the icon_res whitin the 'if'. If moved to the 'else', the icon-tag works with multiple icons per state.

@joBr99 joBr99 merged commit f7b51c3 into joBr99:main Dec 29, 2022
@joBr99 joBr99 added this to the 3.8.X milestone Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants