Merge pull request #1381 from joakim-brannstrom/mutate-fix-assign-in-…

…if-stmt

mutate: relax assignment schema in if stmt

plugin/mutate/source/dextool/plugin/mutate/backend/analyze/pass_clang.d

@@ -541,8 +541,7 @@ final class BaseVisitor : ExtendedVisitor {
     }
 
     private void visitVar(T)(T v) @trusted {
-        auto n = ast.make!(analyze.VarDecl);
-        pushStack(n, v);
+        pushStack(ast.make!(analyze.VarDecl), v);
     }
 
     override void visit(const Directive v) {
@@ -1263,6 +1262,7 @@ void rewriteCondition(ref analyze.Ast ast, analyze.Condition root) {
     import sumtype;
     import dextool.plugin.mutate.backend.analyze.ast : TypeId, VarDecl, Kind;
 
+    // set the type of the Condition to the first expression with a type.
     foreach (ty; BreathFirstRange(root).map!(a => ast.typeId(a))
             .filter!(a => a.hasValue)) {
         sumtype.match!((Some!TypeId a) => ast.put(root, a), (None a) {})(ty);
@@ -1271,7 +1271,7 @@ void rewriteCondition(ref analyze.Ast ast, analyze.Condition root) {
 
     foreach (a; BreathFirstRange(root).filter!(a => a.kind == Kind.VarDecl)) {
         ast.put(root, ast.location(a));
-        root.schemaBlacklist = true;
+        // can't delete the VarDecl explicitly because the code will not compile
         a.schemaBlacklist = true;
         break;
     }

plugin/mutate/test/test_schemata.d

@@ -415,3 +415,23 @@ class ShallGenerateValidSchemaForTerneryOp : SchemataFixutre {
                 r.output);
     }
 }
+
+class ShallGenerateValidSchemaForIfStmtAssign : SchemataFixutre {
+    override string programFile() {
+        return (testData ~ "schemata_ifstmt.cpp").toString;
+    }
+
+    override void test() {
+        mixin(EnvSetup(globalTestdir));
+        precondition(testEnv);
+
+        makeDextoolAnalyze(testEnv).addInputArg(programCode).addPostArg([
+                "--mutant", "all"
+                ]).run;
+
+        auto r = runDextoolTest(testEnv).addPostArg(["--mutant", "all"]).run;
+
+        testAnyOrder!SubStr(["Skipping schema because it failed to compile"]).shouldNotBeIn(
+                r.output);
+    }
+}

plugin/mutate/testdata/schemata_ifstmt.cpp

@@ -0,0 +1,19 @@
+/// @copyright Boost License 1.0, http://boost.org/LICENSE_1_0.txt
+/// @date 2021
+/// @author Joakim Brännström (joakim.brannstrom@gmx.com)
+
+char* fn1() { return nullptr; }
+bool fn2() { return true; }
+bool fn3(int x) { return true; }
+
+int main(int argc, char** argv) {
+    if (char* x = fn1()) {
+        argv[0] = nullptr;
+    }
+    if (bool x = fn3(42)) {
+    }
+    if (fn2()) {
+    }
+
+    return 0;
+}