Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update got and fix indentation #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

suda
Copy link

@suda suda commented Oct 2, 2018

This PR will update got to 9.2.2 and fix the indentation of got.html file to match got.js.

@joakimbeng
Copy link
Owner

Sorry for the slow response... But the .travis.yml needs to be updated to use a later NodeJS version because of new JavaScript syntax being used (which is a breaking change btw)

@suda suda force-pushed the master branch 2 times, most recently from 184968a to 7a70219 Compare May 9, 2019 11:50
@suda
Copy link
Author

suda commented May 9, 2019

Oh I wasn't aware that newer Got broke it. I updated Travis CI config.

As for the breaking change, current Node-RED version requires Node.js >= 8 so IMO this change should be fine as long as this package gets published with bumped minor/major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants