Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for decoding non-const enums. #25

Merged
merged 2 commits into from
Sep 24, 2020

Conversation

rhofour
Copy link

@rhofour rhofour commented Sep 23, 2020

This required bumping up the target to ES2017. The syntax is a little redundant since you need the enum both as a parameter and a template parameter, but it doesn't look like there's a way to get the values of an enum at compile time from the template parameter.

@joanllenas
Copy link
Owner

Hi @rhofour, thanks for your contribution!
The code part looks perfect, just a couple of minor things.

  • The target field in the tsconfig.ts file can stay as 'es5' and everything will work just fine. We need that in order to support ie11.
  • Could you please add a documentation section in the readme file following the format of the rest of the file?

Thanks!

Copy link
Owner

@joanllenas joanllenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhofour
Copy link
Author

rhofour commented Sep 24, 2020

Done. I also bumped the version.

@joanllenas joanllenas merged commit f61ddb5 into joanllenas:master Sep 24, 2020
@joanllenas
Copy link
Owner

Thanks! the new version is ready!
https://github.com/joanllenas/ts.data.json/releases/tag/v1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants