Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo under "Important Dates" #42

Closed
kellyhogan opened this issue Feb 12, 2018 · 6 comments
Closed

Typo under "Important Dates" #42

kellyhogan opened this issue Feb 12, 2018 · 6 comments
Labels

Comments

@kellyhogan
Copy link
Contributor

kellyhogan commented Feb 12, 2018

On the home page under Important Dates, the phrase should be "Midterm Exam (these dates may change if there are any scheduled changes):"

image

Google Chrome Version 63.0.3239.132 (Official Build) (64-bit)

@felixplajer
Copy link
Contributor

"is" should definitely be "if", but I think "schedule" is correct - the exam dates would change if there are changes in the schedule. I don't think it really makes sense to say "scheduled changes" - it's a bit redundant.

@riosr2
Copy link
Contributor

riosr2 commented Feb 13, 2018

I can confirm the issue in Safari Version 9.1.1 (10601.6.17). This can easily be fixed under the index markdown page, https://github.com/joannakl/cs480_s18/blob/gh-pages/index.markdown.

@dorasun
Copy link
Contributor

dorasun commented Feb 13, 2018

Can I have this issue?

@joannakl
Copy link
Owner

@dorasun go ahead and work on this issue

@dorasun dorasun mentioned this issue Feb 20, 2018
@dorasun
Copy link
Contributor

dorasun commented Feb 26, 2018

@kellyhogan I've left you a note with a link to my fork on pull request #70, please confirm if this fix adequately resolves the issue you saw

@kellyhogan
Copy link
Contributor Author

kellyhogan commented Feb 27, 2018

@dorasun sorry, I thought I approved this fix already, but it solves the problem. Thanks!

@joannakl joannakl closed this as completed Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants