Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination customization/localization #15

Closed
guizmo opened this issue Jan 23, 2019 · 4 comments
Closed

Pagination customization/localization #15

guizmo opened this issue Jan 23, 2019 · 4 comments
Assignees
@joaocarmo
Labels
enhancement An enhancement that doesn't translate into a feature

Comments

@guizmo
Copy link

guizmo commented Jan 23, 2019

Hello, thanks for this nice component.
Will you consider adding some sort of customization for the "pagination" ?
like localization or maybe simple arrows ?

Thanks again
@joaocarmo joaocarmo self-assigned this Jan 23, 2019
@joaocarmo joaocarmo added the enhancement An enhancement that doesn't translate into a feature label Jan 23, 2019
@joaocarmo
Copy link
Owner

joaocarmo commented Jan 23, 2019 •
edited
Loading

Hi @guizmo ! This is definitely on the to do list. I'm implementing a way in which a custom React Component can be supplied to render the pagination, while the calculations are performed by the table component. I should be able to deploy it soon. Thank you for the feedback and I'll keep you posted.

@joaocarmo
Copy link
Owner

I just released v0.7.0 which allows for a custom pagination component. Let me know if you find any issue with this. I also replaced the default pagination with a custom implementation.

@guizmo
Copy link
Author

guizmo commented Feb 4, 2019

Sweet ! i'll check that out ASAP

@guizmo
Copy link
Author

guizmo commented Feb 4, 2019

Works great, no bug.
I have reused your helper function and change few thing to use with reactstrap.
Thanks again !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaocarmo joaocarmo

Labels
enhancement An enhancement that doesn't translate into a feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guizmo @joaocarmo