refactor: fx lifecycle parameter name

joaofnds · Jan 9, 2024 · 53fff9b · 53fff9b
1 parent 3fbf89a
commit 53fff9b
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 8 deletions.
diff --git a/adapter/http/fiber.go b/adapter/http/fiber.go
@@ -52,8 +52,8 @@ func NewFiber(config Config, probe Probe) *fiber.App {
 	return app
 }
 
-func HookFiber(lc fx.Lifecycle, app *fiber.App, config Config) {
-	lc.Append(fx.Hook{
+func HookFiber(lifecycle fx.Lifecycle, app *fiber.App, config Config) {
+	lifecycle.Append(fx.Hook{
 		OnStart: func(context.Context) error {
 			go func() {
 				if err := app.Listen(fmt.Sprintf(":%d", config.Port)); err != nil {

diff --git a/adapter/metrics/metrics.go b/adapter/metrics/metrics.go
@@ -23,8 +23,8 @@ func NewServer(c Config) *Server {
 	return &http.Server{Addr: c.Addr}
 }
 
-func HookMetricsHandler(lc fx.Lifecycle, server *Server, logger *zap.Logger) {
-	lc.Append(fx.Hook{
+func HookMetricsHandler(lifecycle fx.Lifecycle, server *Server, logger *zap.Logger) {
+	lifecycle.Append(fx.Hook{
 		OnStart: func(context.Context) error {
 			go func() {
 				err := server.ListenAndServe()

diff --git a/adapter/mongo/mongo.go b/adapter/mongo/mongo.go
@@ -27,8 +27,8 @@ func NewClient(ctx context.Context, config Config) (*mongo.Client, error) {
 	return mongo.Connect(ctx, clientOptions)
 }
 
-func HookConnection(lc fx.Lifecycle, client *mongo.Client, logger *zap.Logger) {
-	lc.Append(fx.Hook{
+func HookConnection(lifecycle fx.Lifecycle, client *mongo.Client, logger *zap.Logger) {
+	lifecycle.Append(fx.Hook{
 		OnStart: func(ctx context.Context) error {
 			err := client.Ping(ctx, nil)
 			if err != nil {

diff --git a/adapter/tracing/tracing.go b/adapter/tracing/tracing.go
@@ -49,12 +49,19 @@ var Module = fx.Module(
 		return provider
 	}),
 
-	fx.Invoke(func(livecycle fx.Lifecycle, exporter *otlptrace.Exporter, provider *sdktrace.TracerProvider) {
-		livecycle.Append(fx.Hook{
+	fx.Invoke(func(
+		lifecycle fx.Lifecycle,
+		exporter *otlptrace.Exporter,
+		provider *sdktrace.TracerProvider,
+	) {
+		lifecycle.Append(fx.Hook{
 			OnStart: func(ctx context.Context) error {
 				return exporter.Start(ctx)
 			},
 			OnStop: func(ctx context.Context) error {
+				if err := exporter.Shutdown(ctx); err != nil {
+					return err
+				}
 				return provider.Shutdown(ctx)
 			},
 		})