New, more functional DSL + remove of the need to declare guard_transition/1 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous DSL used macros mores heavily what is known to be a bad smell. This new DSL relies more on the Machinery module what will result into a more clear and better documentation and a more usual implementation. This new DSL still relies on macros but way less than the previous one.
This aims to enforce users of Machinery to properly declare at least the one required signature of guard_transition/2
This removes the required need to have at least one guard_transition/2 function declared to pattern match into any state transition by using rescue clauses that pattern match into UndefinedFunctionError and FunctionClauseError with the correct expect signature of guard_transition.
joaomdmoura
commented
Dec 11, 2017
lib/machinery.ex
Outdated
| # guard condition exists. | ||
| defp guard_transition(module, struct, next_state) do | ||
| try do | ||
| module.guard_transition(struct,next_state) |
There was a problem hiding this comment.
Space missing after comma
lib/machinery.ex
Outdated
| # transitions are permitted unless another existing | ||
| # guard condition exists. | ||
| defp guard_transition(module, struct, next_state) do | ||
| try do |
There was a problem hiding this comment.
Prefer using an implicit try rather than explicit try.
This adds new tests to cover the new behaviour of the new DSL, it also switch a explicit rescue clause by a implicit one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current DSL on macros more than it should, this new DSL, is more function and also enables Machinery to have a default fallback behavior to the guard transitions.