Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes killing a deemon doesn’t work in the VS Code build #6

Closed
TylerLeonhardt opened this issue Apr 13, 2022 · 9 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@TylerLeonhardt
Copy link

TylerLeonhardt commented Apr 13, 2022

The “Kill VS Code - Build” task doesn't seem always kill the running build task. Often it manages to kill one of 2 running, but not the other.

I’ve noticed this on macOS and some have noticed on Windows.

workaround is to find the deemon process and kill it manually.

Let me know if there’s anything else you need @joaomoreno

@bpasero
Copy link

bpasero commented Apr 13, 2022

Fyi I see this sometimes with the following keyboard shortcut I have configured:

    {
		"key": "cmd+shift+alt+b",
		"command": "workbench.action.tasks.runTask",
		"args": "Restart VS Code - Build"
	}

@joaomoreno
Copy link
Owner

I can't really repro. Also, @TylerLeonhardt are you sure this is deemon related? Might actually be VS Code tasks related.

This will kill both tasks from the command line:

yarn npm-run-all -lp kill-watch-clientd kill-watch-extensionsd

Can you also reproduce if you just run that?

@TylerLeonhardt
Copy link
Author

Yeah... this must be a task thing I guess because I haven't been able to repro using that script... gonna close this until I have more understanding

@TylerLeonhardt
Copy link
Author

I was able to reproduce this:

image

left terminal is me running the command manually
right is the Build task that should be killed

@joaomoreno
Copy link
Owner

It killed one but left another running?

@joaomoreno joaomoreno self-assigned this May 9, 2022
@joaomoreno joaomoreno added the bug Something isn't working label May 9, 2022
@TylerLeonhardt
Copy link
Author

TylerLeonhardt commented May 9, 2022

Yes that's right. And if I run the command over and over again, that surviving process never dies.

Doesn't happen all the time, unfortunately... So I'm not sure what the pattern is.

Any thing else I can grab for you?

@joaomoreno
Copy link
Owner

joaomoreno commented May 16, 2022

@hediet and I figured out the issue! Reproduces if you have really long running builds. Fix coming up!

joaomoreno added a commit that referenced this issue May 16, 2022
joaomoreno added a commit to microsoft/vscode that referenced this issue May 19, 2022
joaomoreno added a commit to microsoft/vscode that referenced this issue May 19, 2022
@yiliang114
Copy link

image

I have encountered a problem that deemon cannot kill a task normally. I try to kill for a long time, but it can't end.
Its performance is that I can't recompile the web extensions and I can't kill it. The log it prints out is the last error log, which should no longer exist now, but it is still output and seems to block the entire task.

hi @joaomoreno, I would like to ask if I have encountered any similar problems ? Or if it has anything to do with this problem?

@yiliang114
Copy link

This problem appears in mac OS 12.2.1 in intel & deemon@1.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants