Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: convert to esm #85

Merged
merged 1 commit into from Sep 17, 2021
Merged

feat: convert to esm #85

merged 1 commit into from Sep 17, 2021

Conversation

daKmoR
Copy link

@daKmoR daKmoR commented Sep 14, 2021

What I did:

  1. npm 7 updated lock to v2
  2. update mocha to support esm
  3. rename index and test to .mjs files (temporarily)
  4. made TreeModel & Node a class and "moved" its prototype function into it

I was hoping github would show it "better" but I basically the only thing I did to the functions is move it into the class and adjust it like that

- Node.prototype.addChildAtIndex = function (child, index) {
+ addChildAtIndex(child, index) {

suggested nest steps:
see #84

@daKmoR daKmoR mentioned this pull request Sep 14, 2021
Open
@daKmoR daKmoR changed the base branch from master to next September 14, 2021 22:23
@daKmoR
Copy link
Author

daKmoR commented Sep 14, 2021

changed the target to next - ready to be merged 🤗

@joaonuno joaonuno merged commit 43efac4 into joaonuno:next Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaonuno joaonuno joaonuno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daKmoR @joaonuno