Correctly map DocumentSymbol's :kind to it's name #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were mapping :kind in DocumentSymbol with names from CompletionItemKind enum, whereas we should have used SymbolKind enum. * eglot.el (eglot--symbol-kind-names): New variable. (eglot-imenu): Use it instead of eglot--kind-names.
|
Looks good, thanks. |
joaotavora
pushed a commit
that referenced
this pull request
Jan 10, 2019
* eglot.el (eglot--sig-info): Protect against invalid label.
bhankas
pushed a commit
to bhankas/emacs
that referenced
this pull request
Sep 18, 2022
* eglot.el (eglot--sig-info): Protect against invalid label.
bhankas
pushed a commit
to bhankas/emacs
that referenced
this pull request
Sep 19, 2022
* eglot.el (eglot--sig-info): Protect against invalid label.
bhankas
pushed a commit
to bhankas/emacs
that referenced
this pull request
Sep 19, 2022
Previously we were mapping :kind in DocumentSymbol with names from the CompletionItemKind enum, whereas we should have used the SymbolKind enum. * eglot.el (eglot--symbol-kind-names): New variable. (eglot-imenu): Use it instead of eglot--kind-names. (#121: joaotavora/eglot#121
bhankas
pushed a commit
to bhankas/emacs
that referenced
this pull request
Sep 19, 2022
* eglot.el (eglot--sig-info): Protect against invalid label. #121: joaotavora/eglot#121
jollaitbot
pushed a commit
to sailfishos-mirror/emacs
that referenced
this pull request
Oct 12, 2022
Previously we were mapping :kind in DocumentSymbol with names from the CompletionItemKind enum, whereas we should have used the SymbolKind enum. * eglot.el (eglot--symbol-kind-names): New variable. (eglot-imenu): Use it instead of eglot--kind-names. GitHub-reference: joaotavora/eglot#121
jollaitbot
pushed a commit
to sailfishos-mirror/emacs
that referenced
this pull request
Oct 12, 2022
* eglot.el (eglot--sig-info): Protect against invalid label. GitHub-reference: per joaotavora/eglot#121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were mapping :kind in DocumentSymbol with names from
CompletionItemKind enum, whereas we should have used SymbolKind enum.
(eglot-imenu): Use it instead of eglot--kind-names.