New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error: Wrong type argument: stringp when creating *sly-completion* buffer #534
Comments
Can't reproduce on an Emacs master build from about 1,5 months ago. Can you confirm this is only in a very recent Emacs 29? |
Sorry for the late reply, as there are many broken builds during July and Aug in the Emacs master branch. I have tested builds in 2022-09-02 (commit: 0ec831b91cde2a0e1b65f99c1190975c6e6959f9) and 2022-08-15 (commit: d5e74d9cd7fd657f13ef7ac72cf84c3bc3a03ba9). Both of them exist the problem I mentioned above. I will update more information if I can find some earlier builds that works. |
Can't reproduce, just tried with the latest commit as of today:
My test:
Everything works as expected |
I think I found the issue. How if you config 2022-09-24.00-38-17.mov |
Well it triggers an issue, but not the issue mentioned above. Furthermore, I can't even get a backtrace. I think the best way is to
followed by a quick manual test (like you have in the gif) Unfortunately, I don't have time to do this bisection right now. Maybe you do? |
Sorry for the late reply.
I'm very willing to do that but might not recently, as I'm busy onboarding my first job this 2 weeks. I will do the test when I'm free. |
Same issue here on Emacs master, and I too have |
This is foremost a regression in Emacs master. It would be good to figure out first when it started failing before thinking about fixes to Sly. |
What does "following Postel" mean? Anyway, i don't think it's starting a
fight to observe that a piece of Elisp worked in a version of Emacs and
doesn't work in a later version. That's usually the definition of a
"regression", unless that piece of Elisp was using some API "illegally".
But I've seen no evidence of that.
…On Wed, Nov 9, 2022, 15:26 Jon Irving ***@***.***> wrote:
I mean, sure, but there's no harm in following Postel with something like
this.
I had a quick look at the git blame for subr.el and there's a *lot* of
new work there, I didn't see a relevant commit from earlier than April this
year in buffer-match-p. Since buffer-match-p explicitly accepts
buffer-or-name, converting it to a buffer, and the doc string specifies:
CONDITION is either:
[ ... ]
- a predicate function that takes a buffer object and ARG as
arguments, and returns non-nil if the buffer matches,
I think "regression" might be a little strong. Perhaps "clarification" or
"tightening up of design" in this case.
But I am not looking for a fight :) Thanks for a great package, and good
luck tracking down the regression and talking someone into fixing it.
—
Reply to this email directly, view it on GitHub
<#534 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC6PQ4IWC32NTF7GGTQCWDWHO7DDANCNFSM6AAAAAAQNRDFWA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I don't think it was intentional. Such things are mentioned in a special
section of the NEWS file. I haven't checked, but I doubt it's there.
…On Wed, Nov 9, 2022, 17:56 Jon Irving ***@***.***> wrote:
I meant Jon Postel, as in the "robustness principle":
Be conservative in what you do, be liberal in what you accept from others.
I was not being disingenuous when I said I didn't want to start a fight. I
meant me, I wasn't accusing you :) I get into trouble because I disagree
with people and use terse language.
Since it is a major version of emacs (i.e., 29 vs 28) I would say it's a
breaking change rather than a regression. I guess it hinges on whether it
was intentional. 🤷
—
Reply to this email directly, view it on GitHub
<#534 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC6PQ4H2U4EMIFVF4MJCSTWHPQWPANCNFSM6AAAAAAQNRDFWA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Finally found time to do the bisection:
The bisection test I used, for reference:
|
Reported to Emacs https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62417. Fix proposed there. |
Just yesterday I ran into this in a Sly w/Emacs compiled from master (I am setting up a fresh dev environment). |
No, the best way is just wait for Eli to finally understand what is going on and solve this in a perfectly equivalent way. Give them time :-) |
"The users can easily make local changes" is completely misguided. Most SLY users aren't even awayre SLY is using |
sounds good, thanks for replying! the timing of seeing this reported and being patched just as yesterday I ran into it. Best workaround I guess is using C-M-i to invoke completion, rather than C-i/TAB. |
Hi, thanks for the work.
When using
sly-symbol-completion-mode
, there is error "(wrong-type-argument stringp #<buffer sly-completions>)" when creating the completion buffer. Screenshot:2022-09-15.23-47-25.mov
Version:
Sly: Master, 805c29672c8a1f6c68286ab379359f9ab9ad9dc2
Emacs: Master, 4cf9c92e27d20da9453f9abe89d84bee5d776329
I think the error is from
sly--completion-transient-mode-display-guard-p
, backtrace listed below:Thanks.
The text was updated successfully, but these errors were encountered: