Don't wrap completing-read #475
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops sorry didn't see #473... |
|
This is OK @theothornhill. Please make a NEWS change, and link #473 in the commit message. use |
Sly wraps `completing-read' to force ido to provide better UX. This is interfering with completion frameworks that don't set the `completing-read-function' such as `vertico' and `mct'. Considering that these packages serve to provide better UX, this functionality shouldn't really be necessary. See joaotavora#473 * lib/sly-messages.el (sly-completing-read): Remove wrapper funcition that only serves to force ido-completion * contrib/sly-mrepl.el (sly-mrepl-shortcut): Use vanilla completing-read * sly.el (sly-read-package-name): Use vanilla completing-read (sly--read-interactive-args): Use vanilla completing-read (sly-prompt-for-connection): Use vanilla completing-read (sly-switch-to-most-recent): Use vanilla completing-read (sly-info): Use vanilla completing-read (sly-db-invoke-restart-by-name): Use vanilla completing-read (sly-read-connection): Use vanilla completing-read (sly-read-inspector-name): Use vanilla completing-read (sly-contrib--read-contrib-name): Use vanilla completing-read
theothornhill
force-pushed
the
completing-read
branch
from
a3283b2
to
b7bf051
Compare
|
Great news! Hopefully the news entry is ok. Updated the commit, should be good now. |
|
I pushed this with some tweaks. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sly wraps
completing-readto force ido to provide better UX. This isinterfering with completion frameworks that don't set the
completing-read-functionsuch asverticoandmct. Considering that thesepackages serve to provide better UX, this functionality shouldn't really be
necessary. This might need a version bump, since it is a user visible change.
See: https://gitlab.com/protesilaos/mct/-/issues/9