Avoid to indent snippets having setup (yas-indent-line 'fixed)

[PierreTechoueyres]

Avoid yas--auto-fill call yas--update-mirrors without setting the snippet environment.

When an snippet like the one bellow is expanded and that auto-fill-mode is activated, the snippet is re-indented when you press space in a field replacement.

# -*- mode: snippet; coding: utf-8-unix -*-
# name: fctb - function ... return boolean
# key: fctb
# expand-env: ((yas-indent-line 'fixed) (yas-wrap-around-region nil))
# --
-------------------------------------------------------------------------------
-- NAME    : ${1:function_name}
-- CREATED : `(capitalize (format-time-string "%d/%m/%Y"))`
-- AUTHOR  : `(and (boundp 'user-ngram) user-ngram)`
-------------------------------------------------------------------------------
-- ARGS  :
-- - $3
-------------------------------------------------------------------------------
-- RETURN  : ${4:True when all is OK, false in any other cases'}
-------------------------------------------------------------------------------
-- DESC : ${5:description}
-------------------------------------------------------------------------------
FUNCTION $1(${3:param})
RETURN   BOOLEAN IS
  v_result BOOLEAN := TRUE;
BEGIN
  trace('${2:package_name}',
        '$1 - start' || lf
     || '$3 => ' || $3);
  $0
  trace('$2', '$1 - End' || lf
     || 'v_result => ' || bool2var(v_result));
  return v_result;
END $1;

when expanded:

-------------------------------------------------------------------------------
-- NAME    : my function
-- CREATED : 22/07/2017
-- AUTHOR  : 
-------------------------------------------------------------------------------
-- ARGS  :
-- - param
-------------------------------------------------------------------------------
-- RETURN  : True when all is OK, false in any other cases'
-------------------------------------------------------------------------------
-- DESC : description
-------------------------------------------------------------------------------
FUNCTION my function(param)
RETURN   BOOLEAN IS
  v_result BOOLEAN := TRUE;
BEGIN
  trace('package_name',
  'my function - start' || lf
  || 'param => ' || param);
  
trace('package_name', 'my function - End' || lf
     || 'v_result => ' || bool2var(v_result));
  return v_result;
  END my function;

with the patch:

-------------------------------------------------------------------------------
-- NAME    : my function
-- CREATED : 22/07/2017
-- AUTHOR  : 
-------------------------------------------------------------------------------
-- ARGS  :
-- - param
-------------------------------------------------------------------------------
-- RETURN  : True when all is OK, false in any other cases'
-------------------------------------------------------------------------------
-- DESC : description
-------------------------------------------------------------------------------
FUNCTION my function(param)
RETURN   BOOLEAN IS
  v_result BOOLEAN := TRUE;
BEGIN
  trace('package_name',
        'my function - start' || lf
     || 'param => ' || param);
  
  trace('package_name', 'my function - End' || lf
     || 'v_result => ' || bool2var(v_result));
  return v_result;
END my function;

• yasnippet.el (yas--auto-fill): reinstate snippet environment before calling yas--update-mirrors.

[npostavs]

Could you put the yas--letenv outside of the mapc please? And use straight quotes in the commit message, it's not markdown.

Otherwise looks good to me, thanks.

[PierreTechoueyres]

I'm not sure what you mean by putting yas--letenv outside the mapc as the yas--snippet-expand-env expect only one snippet and snippets is an list of snippets. Could you please elaborate ?

Sorry for the quotes. Does something like that will agree you ?

 Avoid to indent snippets having setup `(yas-indent-line 'fixed)'

Avoid `yas--auto-fill' call `yas--update-mirrors' without setting
the snippet environment.

[npostavs]

I'm not sure what you mean by putting yas--letenv outside the mapc as the yas--snippet-expand-env expect only one snippet and snippets is an list of snippets. Could you please elaborate ?

Oops! I was talking nonsense.

Sorry for the quotes. Does something like that will agree you ?

Yup, that's fine.

Have you done copyright assignment for Emacs? (the change is small enough to install regardless).

It was bogus

[PierreTechoueyres]

Yes I've done my copyright agreement (for TRAMP and Emacs I think).
I've updated the patch, could you review it ?

[npostavs]

Thanks, merged.

(I put the snippets arg on a separate line because emacs 25+ now colours such things in error-face otherwise. Also removed the#' from the lambda.)

[PierreTechoueyres]

I added the #' to quiet the byte compiler:

yasnippet.el:3637:17:Warning: (lambda (snippet) ...) quoted with ' rather than
    with #'

[npostavs]

Yes, quoting with ' is wrong, quoting with #' is okay, but I prefer the unquoted style (though currently yasnippet.el has a mix). The lambda macro puts in the #' for you.

[PierreTechoueyres]

Ok, I've just asked for my information :-)