Fix to AddComponent: index !== undefined, since (... && index) where …

…index: 0 evaluates as False
joaqim · Jun 27, 2021 · e84cbd0 · e84cbd0
1 parent 439812b
commit e84cbd0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/utils/ecs/entity.spec.ts b/src/utils/ecs/entity.spec.ts
@@ -51,6 +51,17 @@ describe('>>> Entity', () => {
     expect(e.HasComponent(C3)).toBeTruthy()
   })
 
+  it('should be able to remove every component', () => {
+    e.AddComponent(c1)
+    e.AddComponent(c2)
+    e.AddComponent(c3)
+
+    e.RemoveComponent(C1)
+    e.RemoveComponent(C2)
+    e.RemoveComponent(C3)
+    expect(e.Components.length).toBe(0)
+  })
+
   it('should throw error if component wasn\'t found', () => {
     expect(e.HasComponent(C1)).toBeFalsy()
     expect(() => e.GetComponent(C1)).toThrow()

diff --git a/src/utils/ecs/entity.ts b/src/utils/ecs/entity.ts
@@ -39,7 +39,7 @@ export abstract class Entity implements IAwake, IUpdate {
       }
     }
 
-    if (toRemove && index) {
+    if (toRemove && index !== undefined) {
       toRemove.Entity = null
       this._components.splice(index, 1)
     }