Adding locations

jobapis · Jul 25, 2015 · c58ab8e · c58ab8e
1 parent 82e525d
commit c58ab8e
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,24 @@
 # Changelog
 All Notable changes to `jobs-jobs2careers` will be documented in this file
 
+## 0.1.1 - 2015-07-25
+
+### Added
+- Adding name attribute
+- Adding city/state to company and job listing address
+
+### Deprecated
+- Nothing
+
+### Fixed
+- Nothing
+
+### Removed
+- Nothing
+
+### Security
+- Nothing
+
 ## 0.1.0 - 2015-07-04
 
 ### Added

diff --git a/src/J2c.php b/src/J2c.php
@@ -70,7 +70,7 @@ public function createJobObject($payload)
             'date',
             'onclick',
             'company',
-            'city', // Array
+            'city',
             'description',
             'price',
             'id',
@@ -81,16 +81,25 @@ public function createJobObject($payload)
 
         $job = new Job([
             'title' => $payload['title'],
+            'name' => $payload['title'],
             'description' => $payload['description'],
             'javascriptFunction' => $payload['onclick'],
             'javascriptAction' => 'onclick',
             'sourceId' => $payload['id'],
             'industry' => $payload['industry0'],
         ]);
 
-        $job->setDatePostedAsString($payload['date']);
-        $job->setCompany($payload['company']);
-        $job->setLocation($payload['city']);
+        $location = $this->parseLocation($payload['city']);
+
+        $job->setDatePostedAsString($payload['date'])
+            ->setCompany($payload['company']);
+
+        if (isset($location[0])) {
+            $job->setCity($location[0]);
+        }
+        if (isset($location[1])) {
+            $job->setState($location[1]);
+        }
 
         return $job;
     }
@@ -264,4 +273,14 @@ public function getVerb()
     {
         return 'GET';
     }
+
+    /**
+     * Parse city and state from string given by API
+     *
+     * @return array
+     */
+    public function parseLocation($location)
+    {
+        return explode(', ', $location);
+    }
 }
diff --git a/tests/src/J2cTest.php b/tests/src/J2cTest.php
@@ -184,6 +184,7 @@ public function testUrlNotIncludesStartWhenNotProvided()
     public function testItCanCreateJobFromPayload()
     {
         $payload = $this->createJobArray();
+        $payload['city'] = uniqid().', '.uniqid();
         $results = $this->client->createJobObject($payload);
 
         $this->assertEquals($payload['title'], $results->title);