Remove CircleCI. #1189
Merged
Remove CircleCI. #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For some weird reasons, the build is triggered on ReadTheDocs (https://readthedocs.org/projects/joblib/builds/) but the CI status is not shown here. Needs a further look. |
|
OK the readthedocs CI status is here now without any changes 🤷 oh well "c'est tombé en marche" as we say in French 😉. The ReadTheDocs generated for this PR looks fine AFAICT: https://joblib--1189.org.readthedocs.build/en/1189/ |
|
I checked the examples and they look fine, including the compression benchmark results: |
|
Let's merge and disable circle ci. It's always easy to re-enable if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For simplicity, it makes sense to get rid of CircleCI and use ReadTheDocs on PRs since ReadTheDocs is already used to generate the documentation on master.
My main assumption is that CircleCI was only useful to generate the docs on PRs. Let me know if I am missing something!
Fix #1187. For some weird reasons, the doc buil hangs on CircleCI but not on readthedocs so this would be fixed with this PR too.