Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test timeout more informatively on macos CI #1332

Conversation

ogrisel
Copy link
Contributor

@ogrisel ogrisel commented Sep 14, 2022

test_parallel_with_interactively_defined_functions_default_backend happens to be killed from time to time on the slow macos CI host and the error message was not informative.

Using faulthandler in the subprocess script instead should help although I suspect that this wasn't really a deadlock but that the previous 5s timeout was too short for the slow CI host.

Let's see.

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Base: 94.00% // Head: 93.89% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (85f61a1) compared to base (54f4d21).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1332      +/-   ##
==========================================
- Coverage   94.00%   93.89%   -0.11%     
==========================================
  Files          52       52              
  Lines        7301     7303       +2     
==========================================
- Hits         6863     6857       -6     
- Misses        438      446       +8     
Impacted Files Coverage Δ
joblib/test/test_parallel.py 97.05% <100.00%> (ø)
joblib/testing.py 95.23% <100.00%> (+0.23%) ⬆️
joblib/test/testutils.py 50.00% <0.00%> (-50.00%) ⬇️
joblib/_parallel_backends.py 93.01% <0.00%> (-1.84%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ogrisel ogrisel merged commit bdf47e9 into joblib:master Sep 14, 2022
@ogrisel ogrisel deleted the informative-timeout-in-test_parallel_with_interactively_defined_functions_default_backend branch September 14, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant