Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST Fix test_memmapping for Python nogil #1395

Merged
merged 2 commits into from Feb 20, 2023

Conversation

lesteve
Copy link
Member

@lesteve lesteve commented Feb 17, 2023

Another test fix for Python nogil

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Base: 93.89% // Head: 93.89% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (86d88cc) compared to base (e4c00de).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1395   +/-   ##
=======================================
  Coverage   93.89%   93.89%           
=======================================
  Files          52       52           
  Lines        7341     7342    +1     
=======================================
+ Hits         6893     6894    +1     
  Misses        448      448           
Impacted Files Coverage Δ
joblib/test/test_memmapping.py 99.25% <100.00%> (+<0.01%) ⬆️
joblib/hashing.py 89.47% <0.00%> (-1.76%) ⬇️
joblib/_parallel_backends.py 92.27% <0.00%> (+0.73%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx @lesteve

@tomMoral
Copy link
Contributor

Merging as the thread_bomb_mitigation in pypy already fails on master.

@tomMoral tomMoral merged commit 834b925 into joblib:master Feb 20, 2023
@lesteve lesteve deleted the nogil-test-memmapping branch March 20, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants