New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge all configs in pyproject.toml #1433
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1433 +/- ##
==========================================
- Coverage 94.93% 94.83% -0.10%
==========================================
Files 44 44
Lines 7439 7439
==========================================
- Hits 7062 7055 -7
- Misses 377 384 +7 ☔ View full report in Codecov by Sentry. |
This is a nice PR. We will keep We just duplicated the PR in #1460 to be able to merge this before the release today. |
@tomMoral, I feel confused when you welcome PR, but instead of adjusting mine/existing, you create a new one with another author... that is not a good way how to motivate anyone to contribute more, sorry 😞
That was my goal, but as I said not very happy 😕 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
the failing docs build seems unrelated and appears on multiple PRs |
Yes this was fixed in #1461 , the PR should now be green for merge |
as
pyproject.toml
already exists in this repo and it is the new python standard, it makes sense to pull all particular configurations and drop redundantsetup.cfg
.As Flake8 does not support
pyproject.toml
I have moved all essential arguments to the single call in CI 🐰